Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding treaties #118

Closed
wants to merge 15 commits into from
Closed

Conversation

bbernicker
Copy link
Contributor

In response to issue #48 I offered to add support for the treaty sources to reporters-db. This PR does so for the treaty sources in Indigo Book T6.

Treaty sources are stored in either the laws.json or reporters.json file depending on which style they more closely resemble. Regardless of where they are stored, they all have cite_type "treaty." The test.py and README.rst files have been updated to recognize "treaty" as a valid cite_type. All examples for all treaties are from Court Listener except for the example for Pan-Am. Treaty Series, which is from a law review article.

I omitted two T6 sources from this PR (Statutes at Large and LEXIS) because they are not exclusive to treaties. Both are already present in reporters-db, and I added a note to the Statutes at Large one explaining that citations there could be to treaties. LEXIS citations are already their own specialty type.

Also, the regex and example for Treaty Series (T.S.) begin with a white space. This is to prevent false positives where T.S. is part of the name of another reporter, but it is an inelegant solution. I tried various lookbehinds and negative assertions, but because they are at the beginning of the string they cause problems.

bbernicker and others added 10 commits August 9, 2022 17:46
Some courts and statutes use the word "section" or the abbreviation "sec." (and the upper-case Section and Sec.) when citing to the U.S. Code. I updated the regex for the U.S. Code to recognize these alternate forms and also added an example to the list.

See e.g. Whistleblower 21276-13W v. Commissioner, 147 T.C. 121, 147 T.C. No. 4 (2016) ("The targeted taxpayer pleaded guilty to a violation of 18 U.S.C. sec. 371."); McCorkle v. Commissioner, 124 T.C. 56, 57 (2005) ("The order specified that the $2 million was subject to criminal forfeiture pursuant to 18 U.S.C. sec. 982 (2000)."); Kentucky Revised Statutes 403.720 ("'Foreign protective order' means any judgment, decree, or order of protection which is entitled to full faith and credit pursuant to 18 U.S.C. sec. 2265 that was issued on the basis of domestic violence and abuse."); Brown v. Johnson, 387 F.3d 1344, 1347 (11th Cir. 2004) ("On July 15, 2003, the district court denied Brown's motion to amend his complaint because Brown's complaint was subject to dismissal under the PLRA, 28 U.S.C. section 1915."); Wood v. United States, 991 F.2d 915 (1st Cir. 1993) ("Upon filing this certificate, the Attorney General can remove the case to federal court (if it started in state court), substitute the United States as defendant, and, effectively, immunize the employee from any personal liability. 28 U.S.C. Section 2679(d)."); Morana v. Hernando County, CASE NO. 8:09-CV-347-T-17EAJ., 2009 BL 216888 (M.D. Fla. Oct. 7, 2009) ("This case was removed from the Hernando County Circuit Court under 28 U.S.C. Sec. 1332, 28 U.S.C. Sec. 1391, 28 U.S.C. Sec. 1446 and 28 U.S.C. Sec. 1453.").
This addresses freelawproject#116 by adding support for public law citations.
This push commit includes some fixes to the public law definition and also adds support for private law. These have become very rare (~2-3 per decade) but I included them for completeness. If there are no private laws cited in the data, we can remove this option.
This change added support for plurals of section, sec., and the symbol. I also fixed an ineffective escape character and confirmed that this PR passes the tests.
The applicable regulation prefers the cite FCC 2d to the one we have as listed as cannonical. See 47 CFR § 1.14. The Solicitor General also uses the form without periods. See e.g. U.S. Br., FCC v. Prometheus Radio Project, No. 19-1231 (U.S. 2020). I made this preferred form a variation because the Indigo book recommends the current form (T2). This commit was previously made incorrectly (4d3e1ea) but should work now.
This commit lays the groundwork for adding treaties. It modifies the test files and documentation to recognize "treaty" as a valid cite_type. It also updates the note on for the Statutes and Large to indicate that some of those citations may be to treaties if they predate 1949. I opted not to modify the sources which could be statutes or treaties (statutes at large and Lexis) because most citations from those sources are not to treaties.
This commit adds the Indigo Book T6 treaty sources to reporters-db. Treaty sources are stored in either the laws.json or reporters.json file depending on which style they more closely resemble. Regardless of where they are stored, they all have cite_type "treaty." I omitted two sources (Statutes at Large and LEXIS) which are not exclusive to treaties and were already present in reporters-db. Also, the regex and example for Treaty Series (T.S.) begin with a white space. This is to prevent false positives where T.S. is part of the name of another reporter, but it is an inelegant solution. I tried various lookbehinds and negative assertions, but because they are at the beginning of the string they cause problems. All examples for all treaties are from Court Listener except for the example for Pan-Am. Treaty Series, which is from a law review article.
@bbernicker
Copy link
Contributor Author

Sorry I am new to GitHub and somehow messed this up. It should only have the two commits "Groundwork for new treaties" and "Added treaties." I will close this and submit a new PR with only thosw two now.

@bbernicker bbernicker closed this Aug 31, 2022
@mlissner
Copy link
Member

I feel like everybody does whatever this mistake was all the time. I still do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants