Cleanup sqlite #1139
Draft
Cleanup sqlite #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iduartgomez
reviewed
Jun 24, 2024
| @@ -28,7 +28,7 @@ impl Pool { | |||
| #[cfg_attr(feature = "redb", allow(unused))] | |||
| pub async fn new(db_dir: Option<&Path>) -> Result<Self, SqlDbError> { | |||
| let opts = if let Some(db_dir) = db_dir { | |||
| let file = db_dir.join("freenet.db"); | |||
There was a problem hiding this comment.
did you try running with sqlite to see things initialise properly?
There was a problem hiding this comment.
I tried to use sqlx with sqlite only in standalone project, and find that this only a file. But not try it with the freenet cli.
There was a problem hiding this comment.
Compile and install locally freenet to use SQLite and not Redb, install and try run ping contract to see everything works correctly before merging
There was a problem hiding this comment.
@iduartgomez @al8n Still relevant?
There was a problem hiding this comment.
Yes please leave this open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.