Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: divider margin #508

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix: divider margin #508

merged 2 commits into from
Jan 9, 2025

Conversation

dornelasnelson
Copy link
Contributor

What

Fixes Divider margins to 0.5rem instead of 1rem as it was too big.

Media

The only place we are currently using looked like this with 1rem:
image

With 0.5rem it looks as expected:
image

@lloydaf lloydaf self-requested a review January 8, 2025 18:12
Copy link
Contributor

@lloydaf lloydaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we override this programmatically? I feel like maybe we should make this more flexible

@dornelasnelson
Copy link
Contributor Author

Can we override this programmatically? I feel like maybe we should make this more flexible

yes @lloydaf , we can override it! it's pretty flexible but I thought it would be better if it was with the 0.5rem as the first usage of it would already be overwritten

@dornelasnelson dornelasnelson merged commit a248920 into main Jan 9, 2025
10 checks passed
@dornelasnelson dornelasnelson deleted the fix-divider-margin branch January 9, 2025 08:08
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
### [2.21.2](v2.21.1...v2.21.2) (2025-01-09)

### Bug Fixes

* divider margin ([#508](#508)) ([a248920](a248920))
Copy link
Contributor

github-actions bot commented Jan 9, 2025

🎉 This PR is included in version 2.21.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants