Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify receivers #453

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Simplify receivers #453

wants to merge 8 commits into from

Conversation

nitishr
Copy link
Contributor

@nitishr nitishr commented Dec 27, 2019 •
edited
Loading

  • Make naming more consistent with other names/concepts in the codebase: StubbedReceiver and {Any,}InstanceReceiver similar to StubbedMethod and {Any,}InstanceMethod, Impersonating{Any,}InstanceName as opposed to Impersonating{AnyInstance,}Name
  • stubbee usage compatible with the meaning in stubbee -> stubba_object, mock_owner -> stubbee #463
  • make {moch,stubb}a_example_test individually runnable as acceptance tests through include AcceptanceTest

@nitishr
add is_a?(Class) check to AnyInstanceReceiver
f9a2dc1 
... since this will always be true for classes, and reduces variance between
ObjectReceiver and AnyInstanceReceiver. This will allow us to reduce duplication
@nitishr
extract mock_owner to eliminate variance in mocks
1fb156b 
This will allow us to extract superclass or module since mock_owner is the only
difference between ObjectReceiver and AnyInstanceReceiver
@nitishr
extract superclass StubbedReceiver
c9fba41
@nitishr
rename ObjectReceiver to InstanceReceiver
485438a 
This makes the parallel between {Stubbed,Instance,AnyInstance}{Method,Receiver}
more apparent
@nitishr
merge Fake{,AnyInstance}Class into FakeClass
98e7003
@nitishr
set up {Moch,Stubb}aExampleTest as acceptance tests
ba9b62f
@nitishr
rename ImpersonatingName to ImpersonatingInstanceName
a70c3ab 
... to make parallels with {Instance,AnyInstance}{Method,Receiver} more apparent
@nitishr nitishr requested a review from floehopper January 16, 2020 08:58
@floehopper floehopper changed the base branch from master to main July 24, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floehopper floehopper Awaiting requested review from floehopper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nitishr