-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in a part_svc.comment, with ability to edit/view #49
base: FREESIDE_4_BRANCH
Are you sure you want to change the base?
Conversation
->insert works, but apparently there is currently an issue with ->replace, debugging now |
Fix bug where interface wouldn't post the comment field across the various svc_column elements
Interface usage should now be fixed. |
You added the column, and the ability to edit it, but it doesn't do anything else. Can you please share a complete change that shows where this field would be displayed in the interface? |
I didn't do that yet just waiting to see if it was worth doing based on On Tuesday, September 8, 2015, Freeside Internet Services, Inc. <
Jayce^ Preparing Deseret - UtahPreppers |
Sure, it seems like it fits. I'd have to know specifically where you intend to add it in the interface to provide more feedback than that. I don't think it is ready to merge until it is a complete change that displays in the interface in an appropriate way in additional to the database and edit changes. |
Agreed on the merge. I posted it just to have some source material to On Tue, Sep 8, 2015 at 6:37 PM, Freeside Internet Services, Inc. <
Jayce^ Preparing Deseret - UtahPreppers |
orthogonal to the part_pkg.comment.