Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in a part_svc.comment, with ability to edit/view #49

Open
wants to merge 2 commits into
base: FREESIDE_4_BRANCH
Choose a base branch
from

Conversation

Jayceh
Copy link
Contributor

@Jayceh Jayceh commented Aug 31, 2015

orthogonal to the part_pkg.comment.

@Jayceh
Copy link
Contributor Author

Jayceh commented Aug 31, 2015

->insert works, but apparently there is currently an issue with ->replace, debugging now

Fix bug where interface wouldn't post the comment field across the various svc_column elements
@Jayceh
Copy link
Contributor Author

Jayceh commented Aug 31, 2015

Interface usage should now be fixed.

@freeside
Copy link
Owner

freeside commented Sep 9, 2015

You added the column, and the ability to edit it, but it doesn't do anything else. Can you please share a complete change that shows where this field would be displayed in the interface?

@Jayceh
Copy link
Contributor Author

Jayceh commented Sep 9, 2015

I didn't do that yet just waiting to see if it was worth doing based on
your feedback. If you think it fits then yes, I'll finish it and add it to
the pull request so the interface is usable.

On Tuesday, September 8, 2015, Freeside Internet Services, Inc. <
[email protected]> wrote:

You added the column, and the ability to edit it, but it doesn't do
anything else. Can you please share a complete change that shows where this
field would be displayed in the interface?


Reply to this email directly or view it on GitHub
#49 (comment).

Jayce^

Preparing Deseret - UtahPreppers
ΜΟΛΩΝ ΛΑΒΕ

@freeside
Copy link
Owner

freeside commented Sep 9, 2015

Sure, it seems like it fits. I'd have to know specifically where you intend to add it in the interface to provide more feedback than that. I don't think it is ready to merge until it is a complete change that displays in the interface in an appropriate way in additional to the database and edit changes.

@Jayceh
Copy link
Contributor Author

Jayceh commented Sep 9, 2015

Agreed on the merge. I posted it just to have some source material to
discuss. Will finish out the rest and submit.

On Tue, Sep 8, 2015 at 6:37 PM, Freeside Internet Services, Inc. <
[email protected]> wrote:

Sure, it seems like it fits. I'd have to know specifically where you
intend to add it in the interface to provide more feedback than that. I
don't think it is ready to merge until it is a complete change that
displays in the interface in an appropriate way in additional to the
database and edit changes.


Reply to this email directly or view it on GitHub
#49 (comment).

Jayce^

Preparing Deseret - UtahPreppers
ΜΟΛΩΝ ΛΑΒΕ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants