Throw error if server responds with non-OK HTTP status #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
changed the title
fregante
changed the title
robertknight
added a commit
to hypothesis/browser-extension
that referenced
this pull request
Apr 15, 2024
This incorporates the change in fregante/chrome-webstore-upload#82 which should make debugging the issue seen in https://github.com/hypothesis/browser-extension/actions/runs/8690439751/job/23831165514 easier.
robertknight
added a commit
to hypothesis/browser-extension
that referenced
this pull request
Apr 15, 2024
This incorporates the change in fregante/chrome-webstore-upload#82 which should make debugging the issue seen in https://github.com/hypothesis/browser-extension/actions/runs/8690439751/job/23831165514 easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches got's behavior, which was removed in #74
It doesn't actually catch all the API errors though, like on
upload, because they return a 200 OK HTTP response.Followup in: