-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined keywords #22
base: master
Are you sure you want to change the base?
Conversation
db9f7a8
to
80512fe
Compare
It looks like |
The syntax is quite alike |
054dcce
to
c89f755
Compare
Syntax entities are now grouped by combinator precedence. The identification whether a component should be included or not is simplified but will likely be revised when component combinations will be implemented. I'm a bit surprised that this didn't cause any change to the definitions. You know that feeling when you've no clue why it works and you're convinced that you're not doing it completely right. But when you fix it, the output is completely identical. 😆 |
c89f755
to
313f2d1
Compare
313f2d1
to
3efdd20
Compare
3efdd20
to
34ca26c
Compare
867f5cb
to
a7fbd63
Compare
34ca26c
to
b885649
Compare
In case this is proving hard to implement, allow me to propose something simple: I think most people who care about type safety, would be willing to forego the ability to use combined literals in exchange for getting rid of these interface Options {
} this could then be overridden by the user with module augmentation: declare module 'options' {
export interface Options {
allowCombinedKeyword: true;
}
} and finally used in a conditional type expression to determine if the |
It's a bit complicated to implement, yes. But I've made some progress and I'm planning to resume that work after I my vacation. Hopefully! 😸 That case you're suggesting doesn't make things a lot easier. We would need to be selective and ignore I would rather put my efforts in finishing this. Sorry. |
Hey guys, I got hit with this issue too. I’d like my cas to be all types, in a similar fashion as react-native, but I was very surprised to find out this is not the case with the web unforthnately. What is the status with this PR? |
Combined literals would expand many properties and get rid of the
| string
. I did some smaller try outs but I realized that the syntax parser needs to group by combinator precedence for this to become less complicated. The real challenge after that is to combine different combinators with different multipliers. But I would be happy with just something to start with as long as nothing but| string
is removed and no literals as of today.| string
fromdisplay
| sting
fromalign-content
Fixes #8