Update Bandtastic.py #309
Open
Update Bandtastic.py #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated populate_entry_trend and populate_exit_trend to follow new practices
xmatthias
reviewed
Apr 21, 2024
| @@ -129,7 +129,7 @@ def populate_buy_trend(self, dataframe: DataFrame, metadata: dict) -> DataFrame: | |||
|
|
|||
| return dataframe | |||
|
|
|||
| def populate_sell_trend(self, dataframe: DataFrame, metadata: dict) -> DataFrame: | |||
| def populate_exit_trend(self, dataframe: DataFrame, metadata: dict) -> DataFrame: | |||
There was a problem hiding this comment.
well if we do update this part - then we should follow through with all of the strategy migration guide - which doesn't just include this change - but also others (for example updating the dataframe columns to enter_long instead of buy - just to name one without checking for other points).
Otherwise, it'll become some odd middle-state - which is not guaranteed to work in all instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated populate_entry_trend and populate_exit_trend to follow new practices