Skip to content

Commit

Permalink
Fix release flow for JS packages (#2231)
Browse files Browse the repository at this point in the history
# Goal
The goal of this PR is to fix an issue noticed with the v1.15.1 release
around JS packages.

1. The step `is-full-release` wasn't there, but GitHub was happily
resolving the if conditions that tried to use it.
2. NPM changed the tag default, so `latest` was working for
`api-augment` even when it shouldn't have been.

For the v1.15.1 runs see:
-
https://github.com/frequency-chain/frequency/actions/runs/12129502202/job/33851319975
-
https://github.com/frequency-chain/frequency/actions/runs/12129502202/job/33851321973
  • Loading branch information
wilwade authored Dec 4, 2024
1 parent 7371f77 commit 0052a5f
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1050,6 +1050,11 @@ jobs:
uses: actions/checkout@v4
with:
ref: ${{env.RELEASE_BRANCH_NAME}}
- name: Full Release?
id: is-full-release
uses: ./.github/workflows/common/is-full-release
with:
version-tag: ${{env.NEW_RELEASE_TAG}}
- name: Set up NodeJs
uses: actions/setup-node@v4
with:
Expand Down Expand Up @@ -1077,7 +1082,7 @@ jobs:
- name: Release Candidate on NPM
if: env.TEST_RUN != 'true' &&
steps.is-full-release.outputs.is-full-release != 'true'
run: npm publish --access public
run: npm publish --tag next --access public
working-directory: ./js/api-augment/dist
env:
NODE_AUTH_TOKEN: ${{secrets.NODE_AUTH_TOKEN}}
Expand All @@ -1091,6 +1096,11 @@ jobs:
uses: actions/checkout@v4
with:
ref: ${{env.RELEASE_BRANCH_NAME}}
- name: Full Release?
id: is-full-release
uses: ./.github/workflows/common/is-full-release
with:
version-tag: ${{env.NEW_RELEASE_TAG}}
- name: Set up NodeJs
uses: actions/setup-node@v4
with:
Expand Down

0 comments on commit 0052a5f

Please sign in to comment.