Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix graph keys on testnet attempt 2 #2232

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

aramikm
Copy link
Collaborator

@aramikm aramikm commented Dec 4, 2024

Goal

The muti-block migration did not work as expected. It looks like the code inside on_initialize did not get executed. I'm out of theories why that would happen but there might be something related to the feature flags. This is another attempt that replaces feature flag attempt with the genesis hash.

Changes

  • replaced feature flags with genesis hash checks
  • Added tighter checks on_initialize (for better readability)

Discussions

If anyone have a theory why the code inside on_initialize didn't get executed on paseo please contact me.

Closes #2227

Checklist

  • Spec version incremented?

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
pallets/stateful-storage/src/lib.rs 82.18% <100.00%> (+0.08%) ⬆️
pallets/stateful-storage/src/migration/v1.rs 82.52% <ø> (-0.98%) ⬇️

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Dec 4, 2024
Copy link
Collaborator

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛳ Round two!

Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do we want to do an rc release to testnet v1.15.2-rc1 (testnet only) and then remove?

@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Dec 4, 2024
@aramikm
Copy link
Collaborator Author

aramikm commented Dec 4, 2024

@wilwade that would be great

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fix the key issues
3 participants