Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reusable Button component #101

Merged
merged 4 commits into from
Jan 18, 2024
Merged

feat: Reusable Button component #101

merged 4 commits into from
Jan 18, 2024

Conversation

rlaferla
Copy link
Contributor

No description provided.

@rlaferla rlaferla linked an issue Jan 17, 2024 that may be closed by this pull request
Reusable Button component #99
Closed
@rlaferla rlaferla changed the title feat: Button component feat: Reusable Button component Jan 17, 2024
@rlaferla rlaferla marked this pull request as draft January 17, 2024 20:43
claireolmstead
claireolmstead reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@claireolmstead claireolmstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for prioritizing reusability.

src/components/Button.svelte Outdated Show resolved Hide resolved
src/components/Button.svelte Show resolved Hide resolved
@rlaferla rlaferla marked this pull request as ready for review January 18, 2024 15:19
@rlaferla rlaferla requested a review from mattheworris January 18, 2024 15:23
mattheworris
mattheworris approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@rlaferla rlaferla merged commit edbe0b6 into main Jan 18, 2024
2 checks passed
@rlaferla rlaferla deleted the 99-reusable-button-component branch January 18, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claireolmstead claireolmstead claireolmstead left review comments

@mattheworris mattheworris mattheworris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reusable Button component
3 participants
@rlaferla @mattheworris @claireolmstead