-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update all files to work with svelte-check #201
update all files to work with svelte-check #201
Conversation
.github/workflows/svelte-check.yml
Outdated
branches: ['main', 'feat/svelte-app', '200-add-svelte-check-to-github-workflows---provider-dashboard'] | ||
pull_request: | ||
branches: ['main', 'feat/svelte-app', '200-add-svelte-check-to-github-workflows---provider-dashboard'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove this branch before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two non-blocking questions/thoughts, but otherwise looks good.
- Pulled
- Ran locally
- Tested by breaking it by reverting one of the changes made.
src/style/app.css
Outdated
@@ -10,7 +10,7 @@ | |||
line-height: 24px; | |||
font-weight: 400; | |||
|
|||
background-color: #fefaf3; | |||
background-color: #fff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to revert this and let #198 take care of it.
Goal
The goal of this PR is to add svelte-check to the github workflows and resolve errors.
Closes #200
Checklist
How To Test the Changes