Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all files to work with svelte-check #201

Conversation

claireolmstead
Copy link
Contributor

@claireolmstead claireolmstead commented Nov 25, 2024

Goal

The goal of this PR is to add svelte-check to the github workflows and resolve errors.

Closes #200

Checklist

  • PR Self-Review and Commenting
  • Docs updated
  • Tests added

How To Test the Changes

  1. Clone the pr branch
  2. ...

@claireolmstead claireolmstead self-assigned this Nov 25, 2024
@claireolmstead claireolmstead linked an issue Nov 25, 2024 that may be closed by this pull request
@claireolmstead claireolmstead marked this pull request as ready for review November 27, 2024 20:34
Comment on lines 5 to 7
branches: ['main', 'feat/svelte-app', '200-add-svelte-check-to-github-workflows---provider-dashboard']
pull_request:
branches: ['main', 'feat/svelte-app', '200-add-svelte-check-to-github-workflows---provider-dashboard']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove this branch before merge

Copy link
Contributor

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two non-blocking questions/thoughts, but otherwise looks good.

  • Pulled
  • Ran locally
  • Tested by breaking it by reverting one of the changes made.

src/routes/become-a-provider/+layout.svelte Outdated Show resolved Hide resolved
@@ -10,7 +10,7 @@
line-height: 24px;
font-weight: 400;

background-color: #fefaf3;
background-color: #fff;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to revert this and let #198 take care of it.

@claireolmstead claireolmstead merged commit 9e7cefe into main Dec 2, 2024
6 checks passed
@claireolmstead claireolmstead deleted the 200-add-svelte-check-to-github-workflows---provider-dashboard branch December 2, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add svelte-check to GitHub workflows - Provider Dashboard
2 participants