-
Notifications
You must be signed in to change notification settings - Fork 4
Fix ci_max after new base-client release #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Marenz
wants to merge
2
commits into
frequenz-floss:v0.x.x
Choose a base branch
from
Marenz:fix_ci_max
base: v0.x.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,7 @@ | |
from dataclasses import dataclass, replace | ||
from datetime import datetime, timezone | ||
from typing import AsyncIterator | ||
from unittest.mock import AsyncMock, MagicMock | ||
|
||
import grpc | ||
import grpc.aio | ||
|
@@ -109,7 +110,7 @@ async def ListMicrogridDispatches( | |
), | ||
) | ||
|
||
async def StreamMicrogridDispatches( | ||
def StreamMicrogridDispatches( | ||
self, | ||
request: StreamMicrogridDispatchesRequest, | ||
timeout: int = 5, # pylint: disable=unused-argument | ||
|
@@ -122,20 +123,37 @@ async def StreamMicrogridDispatches( | |
|
||
Returns: | ||
An async generator for dispatch changes. | ||
|
||
Yields: | ||
An event for each dispatch change. | ||
""" | ||
receiver = self._stream_channel.new_receiver() | ||
|
||
async for message in receiver: | ||
_logger.debug("Received message: %s", message) | ||
if message.microgrid_id == MicrogridId(request.microgrid_id): | ||
response = StreamMicrogridDispatchesResponse( | ||
event=message.event.event.value, | ||
dispatch=message.event.dispatch.to_protobuf(), | ||
) | ||
yield response | ||
|
||
async def stream() -> AsyncIterator[StreamMicrogridDispatchesResponse]: | ||
"""Stream microgrid dispatches changes.""" | ||
_logger.debug("Starting stream for microgrid %s", request.microgrid_id) | ||
Comment on lines
+128
to
+130
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] The nested Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
receiver = self._stream_channel.new_receiver() | ||
|
||
async for message in receiver: | ||
_logger.debug("Received message: %s", message) | ||
if message.microgrid_id == MicrogridId(request.microgrid_id): | ||
response = StreamMicrogridDispatchesResponse( | ||
event=message.event.event.value, | ||
dispatch=message.event.dispatch.to_protobuf(), | ||
) | ||
yield response | ||
else: | ||
_logger.debug( | ||
"Skipping message for microgrid %s", | ||
message.microgrid_id, | ||
) | ||
|
||
_logger.debug("Creating mock stream for microgrid %s", request.microgrid_id) | ||
|
||
mock_stream = MagicMock(name="StreamMicrogridDispatches") | ||
mock_stream.__aiter__.side_effect = stream | ||
mock_stream.initial_metadata = AsyncMock( | ||
side_effect=lambda: _logger.debug( | ||
"Initial metadata requested for microgrid %s", request.microgrid_id | ||
) | ||
) | ||
return mock_stream | ||
|
||
# pylint: disable=too-many-branches | ||
@staticmethod | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, interesting. Maybe other projects could be affected about this, if they didn't remove the casts after moving to use the proper async stub. 🤔
Once more life shows that there are no small or improbable breaking changes 😢