-
Notifications
You must be signed in to change notification settings - Fork 4
feat: enhance README.md with Quick Start section and improved installation instructions #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v0.x.x
Are you sure you want to change the base?
Conversation
e01cf18
to
5b74a4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the README.md with better onboarding experience by adding a Quick Start section and expanding installation options. It also includes a bug fix for CLI timestamp handling to ensure date-only inputs default to midnight UTC.
- Added Quick Start section with an improved code example for faster user onboarding
- Expanded Installation section to include pip, Poetry, and source installation methods
- Fixed CLI timestamp parsing to handle date-only inputs consistently by defaulting to midnight UTC
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
README.md | Enhanced with Quick Start section and multiple installation methods |
src/frequenz/client/dispatch/_cli_types.py | Fixed date-only timestamp parsing to default to midnight UTC |
tests/test_cli.py | Added test coverage for the new FuzzyDateTime date-only parsing behavior |
RELEASE_NOTES.md | Documented the CLI timestamp parsing fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
d246067
to
b5d6ecf
Compare
…ation instructions - Add dedicated Quick Start section for faster onboarding - Expand Installation section with multiple installation methods - Improve code examples and documentation structure Closes: frequenz-floss#182 Signed-off-by: Mathias L. Baumann <[email protected]>
b5d6ecf
to
09f660c
Compare
|
||
```bash | ||
poetry add frequenz-client-dispatch | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would skip this, otherwise we need to include also uv
, conda
, pipenv
, pdm
, etc.
### From Source | ||
|
||
To install from source: | ||
|
||
```bash | ||
git clone https://github.com/frequenz-floss/frequenz-client-dispatch-python.git | ||
cd frequenz-client-dispatch-python | ||
pip install -e . | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also overlaps with the contributing guide, installing in editable mode just to install for use also feels wrong.
## 🚀 Quick Start | ||
|
||
Here's a quick example to get you started: | ||
Get up and running in minutes with this simple example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping up the marketing? 😆
Summary
Closes #182