[FD-149680] Retain triggers by default fix #14
+68
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhuvanesh-sankar
changed the title
bhuvanesh-sankar
requested review from
Ashok-Kalam,
gurukannappa,
anusharvind,
thoppe-dwarakanath,
YuvaneshFreshdesk,
ImAjayS and
sravya-mallapu
as code owners
| @@ -23,12 +23,11 @@ class LockedSwitcher | |||
|
|
|||
| attr_reader :connection | |||
|
|
|||
| def initialize(migration, connection = nil, retain_triggers = false) | |||
There was a problem hiding this comment.
@bhuvanesh-sankar can we not instead make this as retain_triggers = true?
That is by default if the flag is not passed, it will be true and you would also have the option to pass it as false - retaining the original percona behavior. What do you think?
I don't see a use case though to not retain the triggers.
@ImAjayS Your thoughts?
There was a problem hiding this comment.
Thought of this initially, but as you mentioned we don't have an use case to not retain the triggers. So it would be an added logic which is of less / no use in the system. That's why didn't consider this approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently as per the fix in https://github.com/freshworks/large-hadron-migrator/pull/11 we retain triggers only if retain_triggers flag is set to true in migration script. This leads to issues when this flag is missed to be passed while running migration.
Due to this we have to update the logic to retain triggers by default, so we have to remove the retain_triggers check in the logic and preserve triggers by default.
Fix made:
Removed the retain_triggers flag check in the preserve trigger logic