Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker file #48

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Fix docker file #48

merged 1 commit into from
Jul 5, 2023

Conversation

shashigharti
Copy link
Contributor

@shashigharti shashigharti commented Jul 5, 2023 •
edited
Loading

@shashigharti shashigharti requested a review from roll July 5, 2023 05:49
@shashigharti
Copy link
Contributor Author

shashigharti commented Jul 5, 2023 •
edited
Loading

@roll it is ready for review. Thank you!

roll
roll approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shashigharti

I think we definetely need .dockerignore

@shashigharti
Copy link
Contributor Author

Thank you!. Sorry I forgot to add that change.

@roll
Copy link
Member

roll commented Jul 5, 2023

I mean that was a good addition. Merging

@roll roll merged commit 617e738 into main Jul 5, 2023
@roll roll deleted the 31/fix-failing-github-action branch July 5, 2023 07:40
@e-lo e-lo mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roll roll roll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Open Knowledge
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub action failing
2 participants
@shashigharti @roll