Comment the buffering case

fringd · Feb 3, 2024 · 972d57c · 972d57c
1 parent 9d74325
commit 972d57c
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/lib/zipline.rb b/lib/zipline.rb
@@ -28,6 +28,9 @@ def zipline(files, zipname = 'zipline.zip', **kwargs_for_new)
       # If HTTP/1.0 is used it is not possible to stream, and if that happens it usually will be
       # unclear why buffering is happening. Some info in the log is the least one can do.
       logger.warn { "The downstream HTTP proxy/LB insists on HTTP/1.0 protocol, ZIP response will be buffered." } if logger
+
+      # Here it would be good natured to to read and save the ZIP into a tempfile, and serve it from there.
+      # Rack has a Rack::TempfileReaper middleware which could be used for that etc. Maybe one day.
       self.response_body = zip_generator
     else
       # Disable buffering for both nginx and Google Load Balancer, see