Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace zip_tricks with zip_kit #100

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

julik
Copy link
Contributor

@julik julik commented Mar 1, 2024

Since zip_tricks development has been put on hold, replace it with zip_kit. zip_kit is a friendly fork of zip_tricks under MIT license. It includes new features and bug fixes. Use its header/body generation, and use write_file for heuristic storage mode (pick the storage mode which is optimal for the content).

The new zip_kit also has Streamer#rollback! which will be done automatically if an exception occurs within write_file. This is not handled yet in zipline because the "how" of the retries is more an end-user concern.

Paves the way for addressing #78

julik added 2 commits March 1, 2024 15:54
zip_kit is a friendly fork of zip_tricks under MIT license. It includes new features and bug fixes. Use its header/body generation, and use `write_file` for heuristic storage mode (pick the storage mode which is optimal for the content)
@julik
Copy link
Contributor Author

julik commented Mar 1, 2024

@fringd lmk 😉

@fringd fringd merged commit bd20b2d into fringd:master Mar 4, 2024
3 checks passed
@fringd
Copy link
Owner

fringd commented Mar 4, 2024

busy weekend. glad to hear about the friendly fork and continued development of this lovely work ^_^

I'll cut a new version in a few weeks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants