Apply explicit chunked encoding #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise it falls on Puma/other Rack server to determine whether chunking has to be applied. While a good-natured webserver is supposed to chunk automatically, why not do it ourselves if we can?
similar to zip_tricks "next" branch
so that specs may run again. Also relocate dev deps into the gemspec, as keeping them in the Gemfile makes sense only when using Appraisal or the like
Tabs to spaces and all that. Also - nothing prevents us testing with a real ActionController
If the version of ZipTricks already has a buffering enumerator it will be used
Mocking things is great and all, but then it turns into debugging rspec-mocks
|
...well, and clean a few things up 🤷♂️ but everything works |
Closed
|
@fringd mind taking a look? I did take a liberty with buffering into a Tempfile if no streaming is possible but I think it is justified as the buffering won't be in memory and the zip block would be iterated only once |
|
hey this is a great improvement. having it gracefully degrade and log when streaming isn't possible. thanks so much for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise it falls on Puma/other Rack server to determine whether chunking has to be applied. While a good-natured webserver is supposed to chunk automatically, why not do it ourselves if we can?
This is a backport from the changes I am preparing for zip_tricks (the maintenance situation there is a bit unclear ATM but will hopefully improve soon).