This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
Use morph mapping for attachables #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wimski
force-pushed
the
feature/use-morph-map
branch
from
50ca640
to
4d39bdc
Compare
slavarazum
reviewed
May 18, 2021
| @@ -19,4 +19,9 @@ | |||
| <directory suffix=".php">src/</directory> | |||
| </whitelist> | |||
| </filter> | |||
| <php> | |||
| <env name="DB_CONNECTION" value="testing"/> | |||
There was a problem hiding this comment.
Why we need this setup?
There was a problem hiding this comment.
This one line of configuration replaces the entire getEnvironmentSetup method when you only need the default in memory database setup.
https://packages.tools/testbench/getting-started/configuration.html#in-memory-sqlite-connection
| * @return void | ||
| */ | ||
| protected function getEnvironmentSetUp($app) | ||
| { |
There was a problem hiding this comment.
Why you have removed default DB connection setup?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like to use morph mapping for all model references that are written to the database so that moving a model class won't break any data. See the Laravel docs.
This PR only implements morph mapping support for the Froala attachments. Trix still uses the FQN without any way to change that. I've opened a feature request issue for Nova:laravel/nova-issues#3376
Update
Nova has been updated to use morph mapping for Trix in 3.25.0.