This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
always persist pending attachments when using with spatie/nova-translatable #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am trying to do
I am trying to use this package with spatie/nova-translatable package.
Something like this
The problems
When images are selected and sent to be stored as a pending attachment,
FroalaUploadController
'sstore
method return 404. The problem lies with the spatie/nova-translatable package for which I created a PR here.This problem arises after the Problem 1 is solved. Imagine we got around the Problem 1 by overriding a base
Translatable
class as the following.When images are selected, the images are saved pending attachments. But when submitting the form, the pending attachments will not be persisted. This is because
Translatable
'screateTranslatedField
method defines afillUsing
callback on every translatable field. And thefillAttribute
onFroala
will just check if there exists a fill callback and executes and returns that. (It will not persist the pending attachments there as expected).So in this PR, what I did is to run a callback if it exists and then always persist the pending attachments in
fillAttribute
.See this sample project's nova-translatable-with-froala branch to quickly check the issues.
Note: This PR depends on the spatie/nova-translatable PR to be merged.
Thanks :)