Fix state sync issue before editor.html
is available
#227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to miss a model update if the value changes before
editor.html
is available since Froala's internal state onthis.oldModel
will be updated with the new value, but not actually displayed visually becauseeditor.html
is not available.I've tried to simulate a basic case here:
https://codesandbox.io/s/froala-react-h7jg6
I'm sure there's a more elegant way to resolve this, but this PR creates a new internal state flag for
editor.html
availability and triggerssetContent
even if the props match if the editor was not previously available but is now.