[MAIN][FEATURE] Button Component #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnibalDBXD
requested changes
Aug 31, 2022
Comment on lines
+1
to
+7
| import type { NextPage } from "next"; | ||
|
|
||
| import Button from "@/modules/shared/components/buttons/button"; | ||
| import { Container, Stack } from "@chakra-ui/react"; | ||
|
|
||
| const ButtonsDemo: NextPage = () => { | ||
| const clickHandler = () => { |
There was a problem hiding this comment.
Buena idea esta pagina!
Comment on lines
71
to
75
| const sizeProps = { | ||
| sm: { padding: "10px 12px", gap: "8px", height: "40px" }, | ||
| md: { padding: "10px 16px", gap: "8px", height: "44px" }, | ||
| lg: { padding: "10px 24px", gap: "8px", height: "48px" }, | ||
| }[size]; |
There was a problem hiding this comment.
este objeto podrias moverlo afuera del componente
y tendrias algo asi como:
const sizeProps = buttonSizes[size] ?? buttonSizes.md // <- esto es para tener un size por default si el size que le pasas no es correcto
There was a problem hiding this comment.
Moví los estilos de size y demas css al theme
Comment on lines
46
to
60
| border: "1px solid #E2E8F0", | ||
| boxShadow: "0px 1px 3px rgba(0, 0, 0, 0.1), 0px 1px 2px rgba(0, 0, 0, 0.06)", | ||
| _hover: { | ||
| background: "#EDF2F7", | ||
| border: "1px solid #CFD3DC", | ||
| }, | ||
| _focus: { | ||
| background: "#E2E8F0", | ||
| border: "1px solid #CFD3DC", | ||
| }, | ||
| _disabled: { | ||
| opacity: 0.5, | ||
| border: "1px solid #CFD3DC", | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Esto tambien podrias moverlo afuera del componente
if (outline) {
props = {
...props,
...outlineStyles
}
}
AnibalDBXD
requested review from
AnibalDBXD,
9gustin,
dafnecaneda,
gustavoisaacc,
iarabaya,
kevin-dev71 and
tomi-mercado
9gustin
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature name
Button Component
Issue number
Crear componente Button con sus variantes #83
Tasks