Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ING EntryDate fix #66

Closed
BerendSpigt opened this issue Apr 24, 2019 · 4 comments
Closed

ING EntryDate fix #66

BerendSpigt opened this issue Apr 24, 2019 · 4 comments

Comments

@BerendSpigt
Copy link

BerendSpigt commented Apr 24, 2019

I've used this package for years without any problems at all, but suddenly in the past months I got a few transactions with wrong dates. The wrong dates occurred with bounced direct debit transactions. Those transactions are given (by ING) a "value date" which sometimes is weeks earlier than the "entry date".

The main parser doesn't parse the entry date. It only uses the value date and copies the date to the entry date.

According to the spec the Value/Entry format is:
YYMMDD[MMDD]
which is the same as used in the ABN engine.

So I copied the parseTransactionEntryTimestamp function from ABN to ING, and the date parsing is fixed now.

Anyways, thanks for the great package!

@fruitl00p
Copy link
Owner

@BerendSpigt hmmm... interesting.

I'll create a patch and PR to match. Do you have any test data to verify? That way we can make sure it stays fixed too :)

Also, have you looked at the PR #63 ? Does that work for you too and if not, why not ? :)

@lllopo
Copy link

lllopo commented May 22, 2019

This should be fixed for all banks, as it is by MT940 spec. I'm having the same issue while parsing KNAB statements.

@Nayels
Copy link

Nayels commented Jul 3, 2019

Same issue here! Any news?

@fruitl00p
Copy link
Owner

@Nayels / @Nayels the original poster of the issue hasn't responded yet, but lets give it a whirl and see what happens :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants