Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return types for jsonSerialize #92

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

arendjantetteroo
Copy link

@arendjantetteroo arendjantetteroo commented Dec 12, 2023

Refs #91

Php 8 deprecations fixed.

I updated the composer to have php8 as minimum.
Php8.0 has no maintenance anymore (see https://endoflife.date/php), so we might want to bump that up to 8.1 even for a new major release of this package.

Let me know what else is needed.

@arendjantetteroo arendjantetteroo marked this pull request as ready for review December 12, 2023 08:44
@fruitl00p fruitl00p self-assigned this Sep 23, 2024
php 8.4 triggers this deprecation:

Kingsquare\Parser\Banking\Mt940::parse(): Implicitly marking parameter $engine as nullable is deprecated, the explicit nullable type must be used instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants