[243] Upgrade next.js #263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regina-Gimazova
commented
Jun 21, 2022
|
|
||
| // getDataFromTree does not call componentWillUnmount | ||
| // head side effect therefore need to be cleared manually | ||
| Head.rewind(); |
There was a problem hiding this comment.
Regina-Gimazova
commented
Jun 21, 2022
Comment on lines
+3
to
+6
| /// <reference types="next/image-types/global" /> | ||
|
|
||
| // NOTE: This file should not be edited | ||
| // see https://nextjs.org/docs/basic-features/typescript for more information. |
There was a problem hiding this comment.
was added automatically
Regina-Gimazova
commented
Jun 21, 2022
Comment on lines
-17
to
-19
| config.node = { | ||
| fs: 'empty', | ||
| }; |
There was a problem hiding this comment.
If you are using something like node.fs: 'empty' replace it with resolve.fallback.fs: false.
Regina-Gimazova
commented
Jun 21, 2022
| @@ -2,21 +2,15 @@ | |||
| /* eslint-disable no-param-reassign */ | |||
|
|
|||
| const dotenv = require('dotenv'); | |||
| const withPlugins = require('next-compose-plugins'); | |||
| const nextImages = require('next-images'); | |||
| const nextFonts = require('next-fonts'); | |||
There was a problem hiding this comment.
was needed when Nextjs had no support for importing fonts without using plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A brief description of the pull request.
Resolves: #243
Screenshots in case of UI changes
Test plan
List of steps to manually test introduced functionality:
What do need to pay more attention to, some implicit changes that influence the app:
Review notes
While reviewing pull-request (especially when it's your pull-request), please make sure that:
.env.exampleand added to Heroku