comment: threat .j2 files as Jinja2 #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 5, 2024 22:08
Ansible commonly uses .j2 file extensions for Jinja2 template files it relies on. Signed-off-by: Anthony Loiseau <[email protected]>
Signed-off-by: Anthony Loiseau <[email protected]>
Github prettier complains about the heading spaces of comment-j2.md file. Mute it by adding the list item parents. Note that this will likely result in this parent line added several times at the end if all new comments have this line. Maintainer will have to remove those extra lines (minor I guess). Signed-off-by: Anthony Loiseau <[email protected]>
carmenbianca
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible commonly uses
.j2file extensions for Jinja2 template files it relies on.Link: https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_templating.html
changelog.d/<directory>/.[ ] Added self to copyright blurb of touched files.addition pending in another MR, not added here to avoid conflictsAUTHORS.rst.[ ] Wrote tests.[ ] Documented my changes indocs/man/or elsewhere.