Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicates #1072

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Remove duplicates #1072

merged 2 commits into from
Sep 23, 2024

Conversation

tekrei
Copy link
Contributor

@tekrei tekrei commented Sep 12, 2024

  • [] Added a change log entry in changelog.d/<directory>/.
  • Added self to copyright blurb of touched files.
  • Added self to AUTHORS.rst.
  • Wrote tests.
  • Documented my changes in docs/man/ or elsewhere.
  • My changes do not contradict
    the current specification.
  • I agree to license my contribution under the licenses indicated in the
    changed files.

@evelikov
Copy link
Contributor

Fwiw I've sorted and de-duplicated the authors file with #1076. Happy to split to a separate PR, etc.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca
Copy link
Member

Hi! Thanks @tekrei. I've cleaned this up a little more. The list is sorted by number of commits at time of the creation of that list, but I evidently didn't clean it up well enough. I don't really want to do the labour of keeping that list sorted henceforth (alphabetically or otherwise), so @evelikov if you could remove the commit touching AUTHORS.rst, I'd be thankful.

@carmenbianca carmenbianca merged commit 26f0be9 into fsfe:main Sep 23, 2024
15 checks passed
@tekrei tekrei deleted the patch-1 branch September 23, 2024 12:17
@evelikov
Copy link
Contributor

Food for thought:

Would it make sense to move the authors to separate file and add 2 lines to the releasing script to generates it. Thus ensuring it's in the correct format, the authors themselves don't need to bother and no more duplicates?

/me quickly ducks and goes to update his PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants