Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warnings #327

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Fix compiler warnings #327

merged 4 commits into from
Apr 30, 2024

Conversation

kevmal
Copy link
Contributor

@kevmal kevmal commented Apr 25, 2024

Fixes #321

  • Fixes compiler warnings
  • Array.varOf no longer constrained to float, test case added
  • Hierarchical clustering no longer constrained to float with test added
  • Matrix.ofCols and Matrix.ofRows remain float specific but warning fixed
  • Quantile.normal and Quantile.normalInPlace also remail float specific

[Required] please make sure you checked that

  • The project builds without problems on your machine

[Optional]

  • Added unit tests regarding the added features

bvenn
bvenn approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@bvenn bvenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for all improvements! 🚀

@bvenn bvenn merged commit ab42e1d into fslaborg:developer Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvenn bvenn bvenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] HierarchicalClustering cannot digest data of generic type anymore
2 participants
@kevmal @bvenn