Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shadowed operators #333

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Update shadowed operators #333

merged 3 commits into from
Jul 3, 2024

Conversation

kevmal
Copy link
Contributor

@kevmal kevmal commented May 15, 2024

Closes #332

round and log10 in FSharp.Stats.Ops (which is auto opened) shadows existing operators. log10 is equivalent and unneeded. round has a different signature than the existing round function.

Changes:

  • remove log10 which is already available
  • rename round to roundTo

[Required] please make sure you checked that

  • The project builds without problems on your machine

[Optional]

  • Added unit tests regarding the added features

@smoothdeveloper
Copy link
Contributor

if we are making breaking changes to Ops members, maybe a good time to remove the AutoOpen?

@bvenn
Copy link
Member

bvenn commented Jul 3, 2024

I thought about adding an obsolete tag to the Ops.fs, but as this just reinstates the previous state that should've been changed, I'm going to merge this PR as it is.

[<AutoOpen>]
[<Obsolete("Ops AutoOpen is deprecated. Use Obs.")>]
module Ops_obsolete = 
    open Ops

@bvenn bvenn merged commit c5444cc into fslaborg:developer Jul 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Rename round operator
3 participants