-
Notifications
You must be signed in to change notification settings - Fork 212
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Format "generation" field in Pubsub notification as a string (#972)
As documented in the storage objects JSON object representation, all fields are "string formatted as the specified value type", including numbers. https://cloud.google.com/storage/docs/json_api/v1/objects#resource-representations `strconv.FormatInt` was used for the "size" field, but this wasn't done for generation. We noticed this when doing local testing, and the messages failed JSON unmarshalling from fake-gcs-server, but were properly unmarshalling from real Google Cloud Storage pubsub messages.
- Loading branch information
1 parent
bc65d6a
commit 66fa719
Showing
2 changed files
with
6 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters