Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

followup changes from #6 #7

Merged
merged 4 commits into from
Apr 28, 2015
Merged

followup changes from #6 #7

merged 4 commits into from
Apr 28, 2015

Conversation

drvink
Copy link
Collaborator

@drvink drvink commented Apr 21, 2015

  • style fixes
  • assembly installer is now signed
  • MSI installer now properly elevates privileges when making changes to machine.config
  • provider now also registers handling of .fsx and .fsscript

@drvink
Copy link
Collaborator Author

drvink commented Apr 24, 2015

@dsyme This fixes some issues in the previous PR and makes the changes you'd asked for, and also takes care of issue #3 (or at least will take care of it next time a NuGet package is released).

@dsyme
Copy link
Contributor

dsyme commented Apr 28, 2015

OK, great, go ahead and merge!

@drvink
Copy link
Collaborator Author

drvink commented Apr 28, 2015

I would, but either I'm doing something wrong or I don't have permission. :) (It says "This pull request can be automatically merged by project collaborators. Only those with write access to this repository can merge pull requests.")

@dsyme
Copy link
Contributor

dsyme commented Apr 28, 2015

That should be fixed now

drvink added a commit that referenced this pull request Apr 28, 2015
@drvink drvink merged commit 71b2e72 into fsprojects:master Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants