Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched to rent an array in Giraffe handler and use PooledList in AsyncVal #465

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Switched to rent an array in Giraffe handler and use PooledList in AsyncVal #465

wants to merge 5 commits into from

Conversation

xperiandri
Copy link
Collaborator

@xperiandri xperiandri commented Mar 23, 2024 •
edited
Loading

Before

Method Mean Error StdDev Median Min Max Op/s Gen0 Gen1 Allocated
BenchmarkSimpleQueryUnparsed 85.76 us 1.232 us 1.092 us 85.72 us 83.60 us 87.16 us 11,660.35 2.1973 - 18.76 KB
BenchmarkSimpleQueryParsed 72.29 us 1.858 us 5.421 us 70.58 us 64.11 us 85.09 us 13,832.25 1.0986 - 9.32 KB
BenchmarkSimpleQueryPlanned 33.19 us 1.559 us 4.474 us 31.79 us 27.82 us 46.85 us 30,131.19 0.8850 - 7.34 KB
BenchmarkFlatQueryUnparsed 239.63 us 4.740 us 10.795 us 241.52 us 223.64 us 270.59 us 4,173.09 7.3242 - 62.97 KB
BenchmarkFlatQueryParsed 207.96 us 2.940 us 2.455 us 207.71 us 202.99 us 212.43 us 4,808.63 5.6152 0.2441 47 KB
BenchmarkFlatQueryPlanned 163.65 us 3.044 us 2.698 us 163.58 us 160.08 us 168.58 us 6,110.62 5.1270 0.2441 43.66 KB
BenchmarkNestedQueryUnparsed 413.30 us 8.226 us 16.987 us 409.96 us 389.94 us 460.48 us 2,419.57 20.5078 0.4883 168.51 KB
BenchmarkNestedQueryParsed 348.44 us 3.702 us 3.463 us 348.09 us 343.57 us 355.37 us 2,869.96 14.1602 - 119.24 KB
BenchmarkNestedQueryPlanned 305.32 us 5.903 us 7.249 us 303.15 us 297.22 us 323.09 us 3,275.30 13.1836 - 108.58 KB
BenchmarkParallelQueryPlanned 62,618.70 us 937.705 us 877.130 us 62,340.86 us 61,426.42 us 64,221.00 us 15.97 - - 279.74 KB

After

Method Mean Error StdDev Median Min Max Op/s Gen0 Gen1 Allocated
BenchmarkSimpleQueryUnparsed 89.63 us 1.688 us 2.820 us 88.33 us 86.25 us 97.69 us 11,157.48 2.3193 - 19.36 KB
BenchmarkSimpleQueryParsed 69.13 us 1.367 us 2.883 us 68.07 us 65.87 us 76.87 us 14,465.45 1.0986 - 9.92 KB
BenchmarkSimpleQueryPlanned 29.83 us 0.373 us 0.311 us 29.82 us 29.25 us 30.25 us 33,522.07 0.9460 - 7.94 KB
BenchmarkFlatQueryUnparsed 263.27 us 4.572 us 4.276 us 262.55 us 257.60 us 271.51 us 3,798.32 8.3008 - 71.34 KB
BenchmarkFlatQueryParsed 237.67 us 3.400 us 3.180 us 236.84 us 232.78 us 242.94 us 4,207.58 6.3477 - 55.44 KB
BenchmarkFlatQueryPlanned 190.26 us 2.911 us 2.723 us 189.99 us 185.39 us 195.14 us 5,255.86 6.3477 0.4883 52.06 KB
BenchmarkNestedQueryUnparsed 407.63 us 3.594 us 3.186 us 406.67 us 403.32 us 412.80 us 2,453.20 20.9961 0.4883 171.81 KB
BenchmarkNestedQueryParsed 365.66 us 3.679 us 3.261 us 364.98 us 361.34 us 373.19 us 2,734.79 14.6484 - 122.54 KB
BenchmarkNestedQueryPlanned 313.22 us 3.549 us 3.320 us 312.46 us 309.24 us 318.56 us 3,192.64 13.6719 - 111.88 KB
BenchmarkParallelQueryPlanned 62,148.46 us 472.287 us 394.381 us 62,091.31 us 61,677.59 us 63,141.53 us 16.09 - - 276.18 KB

Line by line

Method Mean Error StdDev Median Min Max Op/s Gen0 Gen1 Allocated
BenchmarkSimpleQueryUnparsed 85.76 us 1.232 us 1.092 us 85.72 us 83.60 us 87.16 us 11,660.35 2.1973 - 18.76 KB
BenchmarkSimpleQueryUnparsed 89.63 us 1.688 us 2.820 us 88.33 us 86.25 us 97.69 us 11,157.48 2.3193 - 19.36 KB
------------------------------ -------------: -----------: -----------: -------------: -------------: -------------: ----------: --------: -------: ----------:
BenchmarkSimpleQueryParsed 72.29 us 1.858 us 5.421 us 70.58 us 64.11 us 85.09 us 13,832.25 1.0986 - 9.32 KB
BenchmarkSimpleQueryParsed 69.13 us 1.367 us 2.883 us 68.07 us 65.87 us 76.87 us 14,465.45 1.0986 - 9.92 KB
------------------------------ -------------: -----------: -----------: -------------: -------------: -------------: ----------: --------: -------: ----------:
BenchmarkSimpleQueryPlanned 33.19 us 1.559 us 4.474 us 31.79 us 27.82 us 46.85 us 30,131.19 0.8850 - 7.34 KB
BenchmarkSimpleQueryPlanned 29.83 us 0.373 us 0.311 us 29.82 us 29.25 us 30.25 us 33,522.07 0.9460 - 7.94 KB
------------------------------ -------------: -----------: -----------: -------------: -------------: -------------: ----------: --------: -------: ----------:
BenchmarkFlatQueryUnparsed 239.63 us 4.740 us 10.795 us 241.52 us 223.64 us 270.59 us 4,173.09 7.3242 - 62.97 KB
BenchmarkFlatQueryUnparsed 263.27 us 4.572 us 4.276 us 262.55 us 257.60 us 271.51 us 3,798.32 8.3008 - 71.34 KB
------------------------------ -------------: -----------: -----------: -------------: -------------: -------------: ----------: --------: -------: ----------:
BenchmarkFlatQueryParsed 207.96 us 2.940 us 2.455 us 207.71 us 202.99 us 212.43 us 4,808.63 5.6152 0.2441 47 KB
BenchmarkFlatQueryParsed 237.67 us 3.400 us 3.180 us 236.84 us 232.78 us 242.94 us 4,207.58 6.3477 - 55.44 KB
------------------------------ -------------: -----------: -----------: -------------: -------------: -------------: ----------: --------: -------: ----------:
BenchmarkFlatQueryPlanned 163.65 us 3.044 us 2.698 us 163.58 us 160.08 us 168.58 us 6,110.62 5.1270 0.2441 43.66 KB
BenchmarkFlatQueryPlanned 190.26 us 2.911 us 2.723 us 189.99 us 185.39 us 195.14 us 5,255.86 6.3477 0.4883 52.06 KB
------------------------------ -------------: -----------: -----------: -------------: -------------: -------------: ----------: --------: -------: ----------:
BenchmarkNestedQueryUnparsed 413.30 us 8.226 us 16.987 us 409.96 us 389.94 us 460.48 us 2,419.57 20.5078 0.4883 168.51 KB
BenchmarkNestedQueryUnparsed 407.63 us 3.594 us 3.186 us 406.67 us 403.32 us 412.80 us 2,453.20 20.9961 0.4883 171.81 KB
------------------------------ -------------: -----------: -----------: -------------: -------------: -------------: ----------: --------: -------: ----------:
BenchmarkNestedQueryParsed 348.44 us 3.702 us 3.463 us 348.09 us 343.57 us 355.37 us 2,869.96 14.1602 - 119.24 KB
BenchmarkNestedQueryParsed 365.66 us 3.679 us 3.261 us 364.98 us 361.34 us 373.19 us 2,734.79 14.6484 - 122.54 KB
------------------------------ -------------: -----------: -----------: -------------: -------------: -------------: ----------: --------: -------: ----------:
BenchmarkNestedQueryPlanned 305.32 us 5.903 us 7.249 us 303.15 us 297.22 us 323.09 us 3,275.30 13.1836 - 108.58 KB
BenchmarkNestedQueryPlanned 313.22 us 3.549 us 3.320 us 312.46 us 309.24 us 318.56 us 3,192.64 13.6719 - 111.88 KB
------------------------------ -------------: -----------: -----------: -------------: -------------: -------------: ----------: --------: -------: ----------:
BenchmarkParallelQueryPlanned 62,618.70 us 937.705 us 877.130 us 62,340.86 us 61,426.42 us 64,221.00 us 15.97 - - 279.74 KB
BenchmarkParallelQueryPlanned 62,148.46 us 472.287 us 394.381 us 62,091.31 us 61,677.59 us 63,141.53 us 16.09 - - 276.18 KB
------------------------------ -------------: -----------: -----------: -------------: -------------: -------------: ----------: --------: -------: ----------:

@valbers valbers requested review from valbers and Juriyx March 24, 2024 08:55
valbers
valbers requested changes Mar 24, 2024
View reviewed changes
Copy link
Collaborator

@valbers valbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xperiandri is it possible to remove the commits from the previous PRs and have only the commits concerning the changes for this PR in this PR?

src/FSharp.Data.GraphQL.Shared/Helpers/PooledResizeArray.fs Show resolved Hide resolved
@xperiandri xperiandri force-pushed the PooledResizeArray_optimization branch 2 times, most recently from ea6d713 to 693ea56 Compare March 24, 2024 15:13
@xperiandri xperiandri force-pushed the PooledResizeArray_optimization branch from 693ea56 to 255db1f Compare March 24, 2024 18:05
valbers
valbers approved these changes Mar 24, 2024
View reviewed changes
Copy link
Collaborator

@valbers valbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valbers valbers valbers approved these changes

@Juriyx Juriyx Awaiting requested review from Juriyx

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xperiandri @valbers