Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing rule checks #713

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add missing rule checks #713

wants to merge 2 commits into from

Conversation

BennieCopeland
Copy link

Add missing rule checks for

  • UnnestedFunctionNames
  • NestedFunctionNames
  • SuggestUseAutoProperty

@BennieCopeland BennieCopeland mentioned this pull request Jul 7, 2024
Draft
@knocte
Copy link
Collaborator

knocte commented Jul 16, 2024

Sorry again for the delay. Can you:

  • Rename commit msg to say "config hooks" instead of "checks".
  • Given that you have discovered that these rules were not actually working, can you then changed their docs to say correct version in the statement "introduced in vX.Y.Z"?
    Thanks!

@BennieCopeland
Copy link
Author

@knocte I made the requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BennieCopeland @knocte