Ensure proper 'zip-applicative' behavior for async computations #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusty
force-pushed
the
gus/non-sequential-task-ops
branch
from
5a7f149
to
65ecb4e
Compare
gusty
force-pushed
the
gus/non-sequential-task-ops
branch
20 times, most recently
from
c7feb46
to
9718cb6
Compare
gusty
changed the title
gusty
force-pushed
the
gus/non-sequential-task-ops
branch
4 times, most recently
from
6134bcf
to
c7ceb09
Compare
gusty
force-pushed
the
gus/non-sequential-task-ops
branch
from
7696c3c
to
f7ac799
Compare
gusty
force-pushed
the
gus/non-sequential-task-ops
branch
2 times, most recently
from
a530890
to
2911800
Compare
gusty
force-pushed
the
gus/non-sequential-task-ops
branch
12 times, most recently
from
00b56ce
to
9cc1c48
Compare
| #else | ||
| let map2 f x y = async { | ||
| let map2 mapper (async1: Async<'T1>) (async2: Async<'T2>) : Async<'U> = async { |
There was a problem hiding this comment.
a potentially breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect that
computation.zipaccumulates errors, for async, task and valueTask.While trying to assert it, we realized we need to fix some stuff, including some FSharp.Core functions.