Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paket.template "readme" file support. #4035

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

seanamos
Copy link
Contributor

@seanamos seanamos commented Jun 19, 2021

This is another step towards closing #3710

Nuget added the ability to specify a path to a readme file within your package that will be displayed on nuget.org.
This adds the readme field to paket.template.

@seanamos
Copy link
Contributor Author

Checking the failing test, it doesn't seem related to any changes I've made.

The relevant failure output:

ERR:-> Request to 'https://www.myget.org/F/dotnet-core-svc/api/v3/index.json' failed with unknown error (_safeGetFromUrl)
ERR:-> HttpRequestException: An error occurred while sending the request.
ERR:   StackTrace:
ERR:        at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
ERR:        at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
ERR:        at System.Net.Http.HttpClient.<FinishSendAsyncBuffered>d__58.MoveNext()
ERR:-> WinHttpException: Error 12175 calling WINHTTP_CALLBACK_STATUS_REQUEST_ERROR, 'A security error occurred'.
ERR:   StackTrace:
ERR:        at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
ERR:        at System.Threading.Tasks.RendezvousAwaitable`1.GetResult()
ERR:        at System.Net.Http.WinHttpHandler.<StartRequestAsync>d__109.MoveNext()
  Stack Trace:

Visiting https://www.myget.org/F/dotnet-core-svc/api/v3/index.json , it does look like there is a certificate problem which results in the test failing.

@baronfel
Copy link
Contributor

Yep, you're right. That test has been failing on all PRs lately but you've done the first root cause on it.

@seanamos
Copy link
Contributor Author

Some very quick digging and it looks like dotnet.myget.org has been deprecated.

https://docs.microsoft.com/en-us/answers/questions/337663/invalid-certificate-for-mygetorg.html

So the question is then, what to do with the test? Can we just remove it?

@baronfel
Copy link
Contributor

baronfel commented Jul 1, 2021

The failing test issue should be unblocked/fixed by #4042

@forki forki merged commit 6c81e81 into fsprojects:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants