Migrated to FSharp.TypeProviders.SDK NuGet package from referenced files #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-tihon
requested changes
Oct 20, 2023
There was a problem hiding this comment.
@xperiandri I cannot merge it with failed CI, please take a look and explain your motivation for NuGet dependency on SDK.
| nuget FSharp.SystemTextJson | ||
| nuget FSharp.TypeProviders.SDK >= 8 |
There was a problem hiding this comment.
- It is already a recommended way to use SDK? Dependencies always were a pain to TPs
- What is your motivation for this change?
| @@ -194,11 +193,11 @@ type DefinitionCompiler(schema: OpenApiDocument, provideNullable) as this = | |||
| ty, | |||
| getterCode = | |||
| (function | |||
| | [ this ] -> Expr.FieldGetUnchecked(this, providedField) | |||
| | [ this ] -> Expr.FieldGet(this, providedField) | |||
There was a problem hiding this comment.
Please explain this change as well.
Why we should not use Expr methods crafted for TP authors as part of TP SDK?
https://github.com/fsprojects/FSharp.TypeProviders.SDK/blob/master/src/ProvidedTypes.fsi#L536-L539
It is probably because you SDK out of assembly and have no longer assess to them... Hmm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.