-
-
Notifications
You must be signed in to change notification settings - Fork 194
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8b226e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want
--no-restore
to work, then you'll need to update theFantomas
project file with the complete list ofRuntimeIdentifiers
that you want to publish AOT for. When you restore with a list of RIDs, Restore can take that knowledge and include all of the RID-specific packages you would need to target each of those platforms. As it is, if you specific RIDs on the CLI and they aren't known to the the Restore, then the CLI will do an implicit Restore for you to ensure NuGet has all of the RID-specific dependencies.Therefore, for this PR I would suggest adding the explicit RuntimeIdentifiers you would like to support, even if a 'normal' build doesn't use them.
a8b226e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing --no-restore flag to
dotnet pack
makes sense to save duplicated work withdotnet build
. Here we're running 1 publish command and 1 AOT restore command, so it seems like you might as well combine the two?Unless you're suggesting that the AOT restore can share work with the non-AOT restore? I won't claim to be a NuGet expert here.
a8b226e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you specify the RIDs the 'normal' restore should pull in the required assets for the AOT Publish operation as well. There's no distinction as to the 'purpose' of the Restore from the SDK's perspective.