Add etcd test #20
Merged
Add etcd test #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuQQiu
reviewed
Mar 11, 2024
ssyssy
force-pushed
the
add-etcd-test
branch
3 times, most recently
from
b3b32c0
to
cf1e5bb
Compare
LuQQiu
reviewed
Mar 11, 2024
tests/conftest.py
Outdated
| run_cmd_worker = ( | ||
| "docker run --platform linux/amd64 -d --rm --net=alluxio_network -p 28080:28080 -p 29999:29999 -p 29997:29997 " | ||
| "docker run --platform linux/amd64 -d --rm -h localhost --net=alluxio_network -p 28080:28080 -p 29999:29999 -p 29997:29997 " |
There was a problem hiding this comment.
why -h localhost is needed for worker but not for master?
There was a problem hiding this comment.
why need localhost parameter?
There was a problem hiding this comment.
@LuQQiu So when worker register itself into etcd. It uses its own hostname to register. That hostname will be its container hash without specifying the hostname here. So the python client will not get the correct worker host from etcd.
There was a problem hiding this comment.
@ssz1997 is it the recommended way?
There was a problem hiding this comment.
@LuQQiu Tried another way, use alluxio config to do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.