Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyarrow usage test case #38

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Add pyarrow usage test case #38

merged 1 commit into from
Apr 29, 2024

Conversation

ssyssy
Copy link
Collaborator

@ssyssy ssyssy commented Apr 25, 2024

No description provided.

@ssyssy ssyssy requested a review from LuQQiu April 25, 2024 00:49
@ssyssy ssyssy force-pushed the pyarrow-test branch 2 times, most recently from 3b37835 to 3e03adf Compare April 25, 2024 01:28
Copy link
Collaborator

@LuQQiu LuQQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, other than the test dependency, the PR LGTM.
Please create the pyarrow example in the README in the next PR

.github/workflows/ci.yml Outdated Show resolved Hide resolved


def test_alluxio_pyarrow(alluxio_file_system: AlluxioFileSystem):
py_fs = PyFileSystem(FSSpecHandler(alluxio_file_system))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the the PyArrow usage examples in the README.md
especially how can we create the PyFileSystem using other ways, we may not be able to pass in created alluxio_file_system to PyArrow Filesystem but directly pass the arguments to create PyFileSystem directly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will add it in the next PR.

@LuQQiu LuQQiu merged commit 8c6dc03 into main Apr 29, 2024
3 checks passed
@ssyssy ssyssy deleted the pyarrow-test branch May 1, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants