-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the bug after introducing ufs full path as page id #53
Conversation
I have run the fixed alluxiofs with the Alluxio 3.3 locally, it passed the |
@SibylYang please help review and see whether that will break backward compatibility? e.g. whether it can still work with AOS |
I believe that the "fake server" in |
I tested it with alluxio open source cluster running locally. There's no problem with reading files. But there's an error when writing to files. Below code generated the error "io.UnsupportedOperation: not writable". ` with alluxio_fs.open('s3://path/to/file', 'a') as f: |
After using the code in #51 and my change in current PR, I test the write function manually with the latest alluxio os edition, I find the write works. Here is my test script, the same as yours above. import sys
import fsspec
sys.path.append('.')
from alluxiofs import AlluxioClient, AlluxioFileSystem
if __name__ == "__main__":
fsspec.register_implementation("alluxiofs", AlluxioFileSystem, clobber=True)
alluxio_fs = fsspec.filesystem("alluxiofs", etcd_hosts="localhost", etcd_port=2379, target_protocol='s3')
with alluxio_fs.open("s3://yichuan-test/testBucket/test.txt", 'a') as f:
f.write("\n444 new line by alluxio\n") After running the script and open the "s3://yichuan-test/testBucket/test.txt" in the S3 website, the content is as below.
Maybe just any wrong configurations that cause the write error? FYI @LuQQiu @SibylYang |
Right. If I used PR 51 --- the updated handler, then there's no problem with writing |
30df8bb
to
1ea5903
Compare
This reverts commit 689cdcf.
@SibylYang Please help review the PR |
This commit LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In Alluxio 3.3, we use the ufs full path as the fileId, instead of a hash String. It breaks the fsspec/alluxiofs, this PR is used to fix the bugs.