Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CI to GitHub Actions #395

Merged
merged 4 commits into from
Nov 12, 2020
Merged

Migrate CI to GitHub Actions #395

merged 4 commits into from
Nov 12, 2020

Conversation

jacobtomlinson
Copy link
Contributor

@jacobtomlinson jacobtomlinson commented Nov 11, 2020 •
edited
Loading

Closes #391

CI running on fork. Will run on future PRs once merged.

@jacobtomlinson jacobtomlinson mentioned this pull request Nov 11, 2020
Open
@martindurant
Copy link
Member

The version string during running of the test comes out as "'0+untagged.1.g638f18a'", which fails a version check requiring s3fs to be recent enough for fsspec. Can you push some tags to your fork, please, and rerun?

@martindurant
Copy link
Member

(I tried to push a tag, but was denied)

@jacobtomlinson
Copy link
Contributor Author

Thanks @martindurant. Strange you couldn't push as I have the allow edits box checked. Perhaps it's because it's tags and not to the branch.

I've pushed tags and rerun CI.

@martindurant
Copy link
Member

Perhaps it's because it's tags and not to the branch.

Exactly

@martindurant
Copy link
Member

Still says '0+untagged.1.g99267b1' in the build :|

@jacobtomlinson
Copy link
Contributor Author

Hrm strange.

@martindurant
Copy link
Member

OK, merging this, and then I can actually fix the linting problems.

@martindurant martindurant merged commit aeb4c5d into fsspec:master Nov 12, 2020
jacobtomlinson
jacobtomlinson commented Nov 13, 2020
View reviewed changes
.github/workflows/ci.yml
Comment on lines +52 to +53
flake8 s3fs
black s3fs --check
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! Oops

@jacobtomlinson
Copy link
Contributor Author

Thanks for fixing this @martindurant

@jacobtomlinson jacobtomlinson deleted the migrate-to-github-actions branch November 13, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate CI to GitHub Actions
2 participants
@jacobtomlinson @martindurant