Custom Logger Code Review #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftcgearedup
commented
Feb 2, 2018
|
|
||
| public class TeamLog { | ||
| File logFile = new File("sdcard/log.file"); | ||
| public void appendLog(String text, String fileName) |
There was a problem hiding this comment.
add java docs to methods.
| import java.io.IOException; | ||
| import java.io.PrintWriter; | ||
|
|
||
| /** |
There was a problem hiding this comment.
replace with real java docs
| { | ||
| try | ||
| { | ||
| logFile.createNewFile(); |
There was a problem hiding this comment.
test making a file to another folder
| catch (IOException e) | ||
| { | ||
| // TODO Auto-generated catch block | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
test for phone exception. create uncreatable file
| } | ||
|
|
||
| } | ||
| // clear the file |
| } | ||
| } | ||
|
|
||
|
|
ftcgearedup
commented
Feb 8, 2018
| /** | ||
| * @param text the text that you want the log message displays. | ||
| * @param tag the tag is attacjhed to the log message and is used to filter log messages by type. | ||
| */ |
There was a problem hiding this comment.
describe what append log does
| if (!file.exists()) | ||
| { | ||
| try | ||
| { |
There was a problem hiding this comment.
reformat on android studios
| writer.print(""); | ||
| writer.close(); | ||
| } catch (FileNotFoundException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
log this stack trace
make a constant for the log tag TEAM LOG
| * @param text the text that you want the log message displays. | ||
| * @param tag the tag is attacjhed to the log message and is used to filter log messages by type. | ||
| */ | ||
| public void appendLog(String text, String tag) { |
… work, created a constant for the log tag for errors in the log itself, added more detailed java docs.
…d with LiveGraph. the file Data Gram Log was created and loggs to a UDP stream on port 6347.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code adds a custom, customizable logger that comes with the ability to write to any file,