Comment out & link

[cchan]

A slight improvement perhaps. Thanks for maintaining this GitHub repo and all of its PRs!

[qwertychouskie]

@ftctechnh Can we get this merged? Thanks.

[cmacfarl]

I'm thinking maybe the CONTRIBUTING.md text just becomes the PULL_REQUEST_TEMPLATE.md text and do away with the redirect entirely?

[NoahAndrews]

I don't think we want to dump the whole contributing file into the PR description field. Here's what I have for OpenRC: https://github.com/OpenFTC/OpenRC/blob/master/.github/PULL_REQUEST_TEMPLATE.md

It's designed for actual code changes of course, not the sort of thing that we'd consider on this repo.

[cmacfarl]

I think maybe we do want to dump the whole contributing file in the PR description field. As mentioned elsewhere, our software release process really doesn't support direct pulls to ftc_app and 99.5% of PRs here are accidental in nature.

A better approach for changes that people really want to see would be filing of issues, perhaps with a redirect back to a branch on a fork of ftc_app that contains the desired change. I realize that's just kind of a strange workflow because it's effectively a pull request without the pull, but it would reflect the understanding that we don't do pulls directly into ftc_app for the reasons described elsewhere.

Note at any rate that ftc_app, at 850M+ is getting rather unwieldy. We've been using git/github in a form that it's not really designed for (why github has a releases page in the first place) and something needs to give at some point in time. At some point in time FIRST will be forced to change how the SDK is distributed just because it's not reasonable to be storing a gigabyte worth of data in the form of binary blobs (aar revisions) that nobody ever really cares about. And --depth=1 is a workaround not a solution.

[JBYoshi]

https://help.github.com/articles/what-is-my-disk-quota/#file-and-repository-size-limitations

We recommend repositories be kept under 1GB each. This limit is easy to stay within if large files are kept out of the repository. If your repository exceeds 1GB, you might receive a polite email from GitHub Support requesting that you reduce the size of the repository to bring it back down.

Is there any reason FTC isn't using something like Maven for distribution? As far as I can see, that would probably be the easiest way to handle updating, since all a team would have to do to update is change the version number in the Gradle build script and refresh the Gradle data in Android Studio.

[qwertychouskie]

I think in the past the idea was to not need an internet connection when first building, but that's out the window now anyways with changes in Android studio. +1 for Maven/etc. Like ModularFTC.