Spotless instead of intellij formatting
#306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leventeBajczi
force-pushed
the
spotless
branch
from
a28bb5a
to
6488096
Compare
|
So, if I understand correctly, the current state of formatting stays for all files, except the ones that will be changed by later commits. It's hard to imagine the new formatting from just config files, would it be possible to see the difference on a few example files? @leventeBajczi |
|
@AdamZsofi: good idea, I pushed the |
leventeBajczi
force-pushed
the
spotless
branch
from
33b0782
to
5323d7f
Compare
|
Benchexec test report for a selection of SV-Benchmarks (correct / incorrect / all):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the automatic format- and copyright checks, which currently mostly relied on IntelliJ IDEA's
format.shscript, with the spotless project.The main reason for this change is that a simple version update (from
2023.xto2024.x) modified how the code style is applied to Java and Kotlin files. I think this is unacceptable.Further advantages of
spotless:./gradlew spotlessApply)Some disadvantages:
Spotlesscurrently does not support intellij code style XMLsThis PR also reverts recent changes in e37b323 and 185dc7a. These are recent formatting commits that should never happen again. This will hopefully fix merge issues before they are dealt with in e.g. #304.
The formatting rules can be found in java-common.build.kts. I'm open to any suggestion on what formatters, with which options to enable. Please check the plugin's README for options.
I would expect some insights from recent contributors to Theta, such as @mondokm, @RipplB, @AdamZsofi, @szdan97, @as3810t, @csanadtelbisz, @s0mark (Sorry if I missed anyone!)
(Note that on this PR, the checks will most likely fail. I deliberately don't want to re-edit the reverted files.)