Refactor: Navigation components for improved route handling #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated navigation components to ensure accurate route matching by parsing URLs and checking active states across links and dropdowns. Refactored redundant logic and standardized handling of routes with parameters in both mobile and desktop navigation. Enhanced maintainability and consistency in dropdown components.
fuelviews-app bot
pushed a commit
that referenced
this pull request
Feb 8, 2025
Updated navigation components to ensure accurate route matching by parsing URLs and checking active states across links and dropdowns. Refactored redundant logic and standardized handling of routes with parameters in both mobile and desktop navigation. Enhanced maintainability and consistency in dropdown components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description: Refactor: Navigation components for improved route handling
Motivation:
This refactor enhances the navigation components to provide more robust route handling. The previous implementation relied on direct route name comparisons, which did not account for dynamic parameters or URL structures. This change aims to ensure that the navigation accurately reflects the current route, improving user experience by providing consistent active link states.
Key Improvements:
Dynamic Route Handling: The updated components now parse the generated URLs and compare them against the current request path, allowing for better handling of routes with parameters and nested structures.
Simplified Active State Logic: The logic to determine whether a link is active has been centralized and simplified. This ensures that dropdown links correctly reflect their active status based on the current route, enhancing usability.
Consistency Across Components: The refactor applies similar logic across both mobile and desktop navigation components, ensuring a consistent approach to route handling throughout the application.
Code Clarity and Maintainability: By removing redundant checks and streamlining the logic, the code is now easier to read and maintain. This will facilitate future enhancements and reduce the likelihood of bugs related to route management.
This refactor ultimately leads to a more reliable and user-friendly navigation experience in the application, ensuring that users can easily identify their current location within the site structure.