Refactor RobotsTxt.php to correctly generate the Sitemap URLs by appending a forward slash before each sitemap path. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nding a forward slash before each sitemap path.
…tsTxtEnvironmentTest.php and RobotsTxtSitemapTest.php to ensure correct URL formatting.
…re made to ensure that the job runs only if the actor is not Dependabot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request refactors the
RobotsTxt.phpfile to ensure that the generated Sitemap URLs are correctly formatted by appending a forward slash before each sitemap path.Motivation
The current implementation does not consistently include a leading slash in the Sitemap URLs, which can lead to malformed URLs in the
robots.txtfile. This inconsistency can negatively impact search engine crawling and indexing, potentially reducing the visibility of the site's content.Changes Made
generate()method inRobotsTxt.phpto usertrim()on the application URL to remove any trailing slashes.Benefits
By making these changes, we improve the reliability of the Sitemap URLs generated in the
robots.txtfile. This refinement enhances our SEO efforts and ensures that search engines can correctly access and index all site content, ultimately contributing to better site performance in search results.