fix(sdk): fix modification of price and volume unit conversion

fugle-dev · Mar 13, 2024 · 9961193 · 9961193
1 parent 1424464
commit 9961193
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/src/client.ts b/src/client.ts
@@ -75,7 +75,8 @@ export class Client {
 
   // Must login first
   async replacePrice(placedOrder: PlacedOrder, price: number | PriceFlag): Promise<ReplaceOrderResponse> {
-    const order = placedOrder.toObject();
+    const unit = this.sdk.getVolumePerUnit(placedOrder.payload.stockNo ?? "");
+    const order = placedOrder.toModifyObject(unit);
     const response = (typeof price === 'number')
       ? this.sdk.modifyPrice(order, price, PriceFlag.Limit)
       : this.sdk.modifyPrice(order, null, price);
@@ -85,7 +86,8 @@ export class Client {
 
   // Must login first
   async replaceQuantity(placedOrder: PlacedOrder, quantity: number): Promise<ReplaceOrderResponse> {
-    const order = placedOrder.toObject();
+    const unit = this.sdk.getVolumePerUnit(placedOrder.payload.stockNo ?? "");
+    const order = placedOrder.toModifyObject(unit);
     const response = this.sdk.modifyVolume(order, quantity);
     const parsed = JSON.parse(response) as ParsedReplaceOrderResponse;
     return parsed.data;

diff --git a/src/placed-order.ts b/src/placed-order.ts
@@ -47,4 +47,18 @@ export class PlacedOrder {
         {} as OrderResult,
       );
   }
+
+  toModifyObject(unit: number): OrderResult {
+    return Object.entries(this.payload).reduce((object, [key, value]) => {
+      if (
+        key.endsWith("Qty") &&
+        this.payload.apCode &&
+        [ApCode.Odd, ApCode.Emg, ApCode.IntradayOdd].includes(
+          this.payload.apCode
+        )
+      )
+        return { ...object, [key]: String(Math.floor(value * unit)) };
+      return { ...object, [key]: String(value) };
+    }, {} as OrderResult);
+  }
 }