Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for new environments #64

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix tests for new environments #64

wants to merge 4 commits into from

Conversation

debug-ito
Copy link

I fixed package meta-data (hi.cabal and stack.yaml) to fix tests for new environments. I tested with stackage lts-12.26 and lts-14.7.

The diff is:

  • stack.yaml: Upgrade the resolver.
  • stack.yaml: Add "template" package to "extra-deps", because "template" package has been removed from stackage.
  • hi.cabal doctests: Add "temporary" package to "build-depends" to fix build error.
  • hi.cabal doctests: Remove modules about hspec from "other-modules" to fix build error. They are not necessary.

I'm not sure how to fix package.yaml, but probably we should fix it to match the change in hi.cabal.

@debug-ito
stack.yaml: try a new resolver.
07b10b3
@debug-ito
.cabal: remove Spec from doctests test-suite.
b919cb3 
because it emits error because the file name "Spec" does not match
"Main" module it contains.
@debug-ito
.cabal: fix test-suite doctests
41a0649 
- temporary package is necessary
- *Spec modules are not necessary. They emit build error because hspec is not loaded.
@debug-ito
stack.yaml: try lts-14.7
ad848ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@debug-ito