This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
adding deadline to story #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Ari, Yes, I'm afraid it will need specs, both rspec and Jasmine. Would be good if you could put in a request spec that ensures the datepicker is visible for a release and not for other stories. |
|
I should be able to get to those in there this weekend. Still figuring out jasmine. |
added 4 commits
May 11, 2012 14:31
first run at tests for jasmine,model,request
|
Added tests for deadline. If a deadline is present check to make sure it's after the project start date validate that deadlines can only be set on a release. Also added a request spec to ensure that the deadline field is available and a datepicker for releases. |
|
@malclocke how's this for merging? @AriT93 how do you feel about rebasing against current master and squashing the commits down to an easily digestible single commit for this change? |
|
deadlines are cool 👍 |
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the deadline field and updated the view to display it as a datepicker on releases. I still need to write the specs for this, I can kill the pull request and submit them together if that would be better. Sorry for the delay on this.